Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message): disable save on empty message #3317

Merged
merged 4 commits into from
May 31, 2022
Merged

fix(message): disable save on empty message #3317

merged 4 commits into from
May 31, 2022

Conversation

jasonwoodland
Copy link
Contributor

What this PR does πŸ“–

  • Prevents saving an edited message as an empty message
  • Fixes styling and locale strings in the edit message UI

Which issue(s) this PR fixes πŸ”¨
AP-1631

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 27, 2022
@netlify
Copy link

netlify bot commented May 27, 2022

βœ… Yeeeehaw, deploy preview is ready!

Name Link
πŸ”¨ Latest commit 769c46e
πŸ” Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/62904141010de700082ca31f
😎 Deploy Preview https://deploy-preview-3317--adoring-edison-dbcef8.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 27, 2022

βœ… Yeeeehaw, deploy preview is ready!

Name Link
πŸ”¨ Latest commit 5a72d3e
πŸ” Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6295a2ea5834880008ce8869
😎 Deploy Preview https://deploy-preview-3317--adoring-edison-dbcef8.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@josephmcg josephmcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the solution. Could you remove $data and $props mentions and fix intellisense in the file? The computed need return types. Then you can remove the declaration stuff (screenshot below).

Please make a habit of fixing this whenever you see it

image

@josephmcg josephmcg added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels May 27, 2022
@jasonwoodland jasonwoodland removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label May 30, 2022
@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 30, 2022
@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels May 31, 2022
@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels May 31, 2022
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gravacao.do.ecra.2022-05-31.as.02.06.29.mov

if you try to save a empty message doesn't return any feedback to the user when clicking on save

@josephmcg
Copy link
Contributor

true. error toast would be enough.
a nice bonus feature would be making the blue outline red if error, that would be fairly involved though

@jasonwoodland jasonwoodland removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label May 31, 2022
@josephmcg josephmcg added the Ready for QA Ready for QA team to test, Devs approved. label May 31, 2022
@stavares843 stavares843 merged commit e709bc9 into dev May 31, 2022
@stavares843 stavares843 deleted the AP1631 branch May 31, 2022 12:05
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants