Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): disable auto redirect from chat to friend list on first visit #3325

Merged
merged 2 commits into from
Jun 7, 2022
Merged

fix(chat): disable auto redirect from chat to friend list on first visit #3325

merged 2 commits into from
Jun 7, 2022

Conversation

AlexZakablukov
Copy link
Contributor

What this PR does 📖
disable auto redirect from chat to friend list on first visit

Which issue(s) this PR fixes 🔨
AP-1643

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 27, 2022
@netlify
Copy link

netlify bot commented May 27, 2022 •
edited
Loading

✅ Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 8cc03a1
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/629a24e31fefd80008782e25
😎 Deploy Preview https://deploy-preview-3325--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label May 27, 2022
@github-actions github-actions bot removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label May 31, 2022
@Jekrimo Jekrimo removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 31, 2022
@stavares843 stavares843 added the Ready for QA Ready for QA team to test, Devs approved. label May 31, 2022
@phillsatellite phillsatellite added the testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. label May 31, 2022
@stavares843 stavares843 removed the Ready for QA Ready for QA team to test, Devs approved. label May 31, 2022
@phillsatellite phillsatellite added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA Ready for QA Ready for QA team to test, Devs approved. and removed testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. labels Jun 1, 2022
@stavares843 stavares843 removed the Ready for QA Ready for QA team to test, Devs approved. label Jun 1, 2022
@stavares843 stavares843 force-pushed the AP-1643 branch 2 times, most recently from 382942f to f21dd75 Compare June 3, 2022 00:07
molimauro
molimauro reviewed Jun 3, 2022
View reviewed changes
store/friends/actions.ts Outdated Show resolved Hide resolved
molimauro
molimauro reviewed Jun 3, 2022
View reviewed changes
store/friends/actions.ts Outdated Show resolved Hide resolved
@molimauro molimauro added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 3, 2022
@molimauro molimauro removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Jun 3, 2022
@molimauro molimauro added the Ready for QA Ready for QA team to test, Devs approved. label Jun 3, 2022
@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Ready for QA Ready for QA team to test, Devs approved. labels Jun 3, 2022
@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. and removed QA tested One QA Person has tested - Needs QA Lead review still labels Jun 3, 2022
@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. labels Jun 4, 2022
@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. and removed Ready for QA Ready for QA team to test, Devs approved. labels Jun 6, 2022
@stavares843 stavares843 merged commit 7ab5a52 into dev Jun 7, 2022
@stavares843 stavares843 deleted the AP-1643 branch June 7, 2022 13:20
@github-actions github-actions bot removed the testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jekrimo Jekrimo Jekrimo approved these changes

@stavares843 stavares843 stavares843 approved these changes

@molimauro molimauro molimauro approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AlexZakablukov @Jekrimo @stavares843 @molimauro @phillsatellite @WanderingHogan