Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(call): mute button logic #3350

Merged
merged 6 commits into from
Jun 8, 2022
Merged

fix(call): mute button logic #3350

merged 6 commits into from
Jun 8, 2022

Conversation

jasonwoodland
Copy link
Contributor

What this PR does πŸ“–

  • Synchronises mute button with webrtc call state

Which issue(s) this PR fixes πŸ”¨
AP-1647

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@jasonwoodland jasonwoodland added the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label May 30, 2022
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 30, 2022
@netlify
Copy link

netlify bot commented May 30, 2022 •
edited
Loading

βœ… Yeeeehaw, deploy preview is ready!

Name Link
πŸ”¨ Latest commit b5a58f6
πŸ” Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/629fc2cfe85a7e00089ff8bd
😎 Deploy Preview https://deploy-preview-3350--adoring-edison-dbcef8.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jasonwoodland jasonwoodland removed the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label May 30, 2022
@phillsatellite phillsatellite added the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label May 31, 2022
@phillsatellite
Copy link
Contributor

added label for Jeff's comment above

@jasonwoodland jasonwoodland removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Jun 1, 2022
@Jekrimo Jekrimo removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 1, 2022
@stavares843 stavares843 added the Ready for QA Ready for QA team to test, Devs approved. label Jun 1, 2022
@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Ready for QA Ready for QA team to test, Devs approved. labels Jun 1, 2022
@stavares843
Copy link
Member

Captura de ecrã 2022-06-01, às 17 32 52

can we add a tooltip saying ''Not available outside a call'' or something similar? this way adds more feedback to the user

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed QA tested One QA Person has tested - Needs QA Lead review still labels Jun 1, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Jun 1, 2022
@josephmcg josephmcg removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Jun 3, 2022
@josephmcg
Copy link
Contributor

josephmcg commented Jun 3, 2022 •
edited
Loading

im seriously questioning whether we need this button at all if it doesn't work outside of a call.
I would probably use the space to create a settings button. The current settings location has the potential to go offscreen if the user has tons of unread chats, right?

@stavares843 stavares843 force-pushed the AP1647 branch 2 times, most recently from 75de88b to 675bbd9 Compare June 3, 2022 17:39
@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jun 4, 2022
@WanderingHogan
Copy link
Contributor

@josephmcg sounds like a good idea to me, hide if not in call, show if in call. If you want to make a ticket and come back to it that works, it's very low priority right now compared to functionality things that need done, though, so mark it with POST

@josephmcg
Copy link
Contributor

@WanderingHogan that makes life much easier, thanks.

@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. Ready for QA Ready for QA team to test, Devs approved. and removed Ready for QA Ready for QA team to test, Devs approved. testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. labels Jun 6, 2022
@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. labels Jun 7, 2022
@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. and removed testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. labels Jun 7, 2022
@stavares843 stavares843 merged commit 3f7f133 into dev Jun 8, 2022
@stavares843 stavares843 deleted the AP1647 branch June 8, 2022 15:15
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WanderingHogan WanderingHogan WanderingHogan approved these changes

@Jekrimo Jekrimo Jekrimo approved these changes

@stavares843 stavares843 stavares843 approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jasonwoodland @phillsatellite @stavares843 @josephmcg @WanderingHogan @Jekrimo