Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): switch privacy settings loading list to array #3472

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

josephmcg
Copy link
Contributor

What this PR does 📖

  • use array for loading state rather than string
  • This code would incorrectly unlock a remote setting even if it wasn't done loading since the loading state was only a string

Which issue(s) this PR fixes 🔨
AP-1723

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 6, 2022
@netlify
Copy link

netlify bot commented Jun 6, 2022

Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 23fff37
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/629d7396e810aa0008811383
😎 Deploy Preview https://deploy-preview-3472--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@josephmcg josephmcg changed the title fix(settings): switch prviacy settings loading list to array fix(settings): switch privacy settings loading list to array Jun 6, 2022
@Jekrimo Jekrimo added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 6, 2022
@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. and removed Ready for QA Ready for QA team to test, Devs approved. labels Jun 6, 2022
@stavares843 stavares843 merged commit e33d8a2 into dev Jun 7, 2022
@stavares843 stavares843 deleted the AP1723 branch June 7, 2022 12:49
@github-actions github-actions bot removed the testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants