-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(createAccount): better error messages/handling on username error #3505
Conversation
β Yeeeehaw, deploy preview is ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Its fine for now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11928301893102.mov
after the error, reloads the page and goes to the /unlock view
But thats not a new issue, thats the way it's always behaved. If you want to change that, it should be in a separate ticket |
doesn't happen on dev Gravacao.do.ecra.2022-06-08.as.14.56.32.movactually, i can even say that this bug was almost getting introduced in march on a previous PR as you can see, was fixed as well before merging |
oh its the |
Sara and I discussed. I didn't fully understand the issue. will fix tomorrow |
@stavares843 should be better now |
thanks @josephmcg π¨ |
What this PR does π
Which issue(s) this PR fixes π¨
AP-1741
Special notes for reviewers ποΈ
![image](https://user-images.githubusercontent.com/33670767/172541866-c3de67e7-0cbc-421e-a8fb-5f77241de913.png)
Is the native error better regarding accessibility?
Additional comments π€