Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(createAccount): better error messages/handling on username error #3505

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Jun 8, 2022

What this PR does πŸ“–

  • add red border around username while invalid after a user failed submission once
  • make error message update along with our Config values (groups and accounts)
  • remove unused data

Which issue(s) this PR fixes πŸ”¨
AP-1741

Special notes for reviewers πŸ—’οΈ
Is the native error better regarding accessibility?
image

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 8, 2022
@netlify
Copy link

netlify bot commented Jun 8, 2022

βœ… Yeeeehaw, deploy preview is ready!

Name Link
πŸ”¨ Latest commit 0b4541d
πŸ” Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/62a142598663b80008e0480d
😎 Deploy Preview https://deploy-preview-3505--adoring-edison-dbcef8.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@molimauro
Copy link
Contributor

I moved preventDefault lower so the browser error message wouldn't come through. Not sure how we feel about it. Is the native error better regarding accessibility?

Its fine for now :)

@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 8, 2022
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11928301893102.mov

after the error, reloads the page and goes to the /unlock view

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Jun 8, 2022
@josephmcg
Copy link
Contributor Author

But thats not a new issue, thats the way it's always behaved. If you want to change that, it should be in a separate ticket

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jun 8, 2022
@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Jun 8, 2022
@stavares843
Copy link
Member

doesn't happen on dev

Gravacao.do.ecra.2022-06-08.as.14.56.32.mov

actually, i can even say that this bug was almost getting introduced in march on a previous PR

#2447 (review)

as you can see, was fixed as well before merging

@molimauro
Copy link
Contributor

oh its the preventDefault i guess

@josephmcg
Copy link
Contributor Author

Sara and I discussed. I didn't fully understand the issue. will fix tomorrow

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jun 9, 2022
@josephmcg
Copy link
Contributor Author

@stavares843 should be better now

@stavares843
Copy link
Member

thanks @josephmcg πŸ”¨

@stavares843 stavares843 merged commit 1f00f38 into dev Jun 9, 2022
@stavares843 stavares843 deleted the AP1741 branch June 9, 2022 13:29
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants