Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(call): show avatar in incoming call #3511

Merged
merged 2 commits into from
Jun 9, 2022
Merged

fix(call): show avatar in incoming call #3511

merged 2 commits into from
Jun 9, 2022

Conversation

AlexZakablukov
Copy link
Contributor

What this PR does 📖
show avatar in incoming call

Which issue(s) this PR fixes 🔨
AP-1692

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 8, 2022
@netlify
Copy link

netlify bot commented Jun 8, 2022 •
edited
Loading

✅ Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 90f17db
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/62a1a7c8e8fb32000897af04
😎 Deploy Preview https://deploy-preview-3511--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

molimauro
molimauro suggested changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@molimauro molimauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor one

@molimauro molimauro added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 8, 2022
@molimauro molimauro added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jun 9, 2022
@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 9, 2022
@stavares843
Copy link
Member

is missing showing the satellite avatar when user doesn't have the photo adding a task for that to be done later, merging this one

image

but the photo shows fine

image

@stavares843 stavares843 merged commit 5abb875 into dev Jun 9, 2022
@stavares843 stavares843 deleted the AP-1692 branch June 9, 2022 13:59
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Jun 9, 2022
@stavares843
Copy link
Member

AP-1754

@stavares843 stavares843 mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

@molimauro molimauro molimauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexZakablukov @stavares843 @molimauro