Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): always show file size, fix overflow #3825

Merged
merged 4 commits into from
Jul 5, 2022
Merged

fix(chat): always show file size, fix overflow #3825

merged 4 commits into from
Jul 5, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Jun 27, 2022

What this PR does 📖

  • switch file size to beginning of text rather than end
  • overflow long types w/ ellipsis so file embeds look more consistent

image
image

Which issue(s) this PR fixes 🔨
AP-1901

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 27, 2022
@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 27, 2022
@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 27, 2022
@molimauro molimauro removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 29, 2022
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2022-06-29, às 15 44 20

dev vs this branch

if you dont have a subtitle, you have a hifen without any content on front, that way seems something is missing - first arrow

the ''q'' and ''p'' are cut off - second arrow

seed
end electric swear hurdle business priority salad ancient wire change please purpose

Chrome, macOS

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed QA tested One QA Person has tested - Needs QA Lead review still labels Jun 29, 2022
@josephmcg
Copy link
Contributor Author

@stavares843 thanks, should be all better.
I noticed mobile embeds were flowing off the screen too, fixed that as well. I think it was introduced by my timestamp hover stuff

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. depending on other PR Blocked by other PR. Once the other PR has gone in, rebase this branch to dev and test. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. Ready for QA Ready for QA team to test, Devs approved. depending on other PR Blocked by other PR. Once the other PR has gone in, rebase this branch to dev and test. labels Jun 30, 2022
@phillsatellite
Copy link
Contributor

phillsatellite commented Jun 30, 2022

Retested: Made sure I got most recent commits and some other stuff was fixed on here for me to verify but noticed the "p" was still cutoff
this branch
Screen Shot 2022-06-30 at 12 37 37 PM

dev
Screen Shot 2022-06-30 at 12 38 41 PM

@phillsatellite phillsatellite added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Jun 30, 2022
@josephmcg
Copy link
Contributor Author

josephmcg commented Jul 1, 2022

oh interesting, I'll have to take another look at that. we need to add overflow:hidden for the ellipsis feature to work, so that must be what's doing it. maybe i could adjust the line height

@josephmcg
Copy link
Contributor Author

hoping this is better. i removed the .9 line height style that was in place

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jul 5, 2022
@stavares843 stavares843 changed the title fix(chat): always show file size, fix overflow for long mime type fix(chat): always show file size, fix overflow Jul 5, 2022
@stavares843 stavares843 merged commit 057cb52 into dev Jul 5, 2022
@stavares843 stavares843 deleted the AP1901 branch July 5, 2022 12:03
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants