Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal): add fade animation #3859

Merged
merged 9 commits into from
Jul 28, 2022
Merged

feat(modal): add fade animation #3859

merged 9 commits into from
Jul 28, 2022

Conversation

jasonwoodland
Copy link
Contributor

What this PR does 📖

  • Add fade in/out animation to modal

Which issue(s) this PR fixes 🔨
AP-1917

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 29, 2022
josephmcg
josephmcg suggested changes Jun 29, 2022
View reviewed changes
assets/styles/framework/animations.less Outdated Show resolved Hide resolved
components/ui/Modal/Modal.less Outdated Show resolved Hide resolved
@josephmcg josephmcg added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 29, 2022
@stavares843 stavares843 force-pushed the AP1917 branch 2 times, most recently from 30a0af4 to 7194c6a Compare June 30, 2022 12:29
@jasonwoodland jasonwoodland added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jul 1, 2022
@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jul 1, 2022
@phillsatellite
Copy link
Contributor

phillsatellite commented Jul 1, 2022 •
edited
Loading

Found small UI issue when navigating from friends page to the Coming Soon modal looks like you can see the modal sliding in

RPReplay_Final1656698098.mp4

@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. QA tested One QA Person has tested - Needs QA Lead review still labels Jul 1, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Jul 1, 2022
@jasonwoodland
Copy link
Contributor Author

@phillsatellite good spot, was this on safari? I think it was animating the transform-origin value which caused the glitch. Anyway I've moved the transform-origin outside of the animation ruleset.

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa labels Jul 6, 2022
@phillsatellite
Copy link
Contributor

phillsatellite commented Jul 6, 2022 •
edited
Loading

@phillsatellite good spot, was this on safari? I think it was animating the transform-origin value which caused the glitch. Anyway I've moved the transform-origin outside of the animation ruleset.

Hey @jasonwoodland! It was on Safari

@jasonwoodland jasonwoodland changed the base branch from dev to iridium-integration-build-test July 6, 2022 23:58
@jasonwoodland jasonwoodland removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 7, 2022
@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. merge blocked labels Jul 8, 2022
@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. merge blocked and removed Ready for QA Ready for QA team to test, Devs approved. labels Jul 8, 2022
@stavares843 stavares843 added dev iridium-dev missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa and removed testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. merge blocked dev labels Jul 21, 2022
@josephmcg josephmcg merged commit c77d690 into iridium-dev Jul 28, 2022
@josephmcg josephmcg deleted the AP1917 branch July 28, 2022 07:38
@github-actions github-actions bot removed missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa iridium-dev labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmcg josephmcg josephmcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasonwoodland @phillsatellite @josephmcg @stavares843