Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scroll): show scrollbar on hover only option #3957

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

josephmcg
Copy link
Contributor

What this PR does πŸ“–
I initially made a huge PR that affected all scrolls on the app, but then we switched main branches. This is a small chunk of that large pr

  • global scroll style rules
  • add lighter color on hover for webkit (thanks Thomas)
  • I think being able to hide the scrollbar until you hover/focus within an element is useful functionality, but I don't think it should be applied to every scrollbar in the entire app. I created a class (.hover-scroll) which will do this. for now, I added it to the chat sidebar. You can test by manually creating elements via the inspector to trigger the overflow

image

image

Which issue(s) this PR fixes πŸ”¨
AP-1929

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 13, 2022
@WanderingHogan WanderingHogan merged commit d04609e into iridium-dev Jul 15, 2022
@WanderingHogan WanderingHogan deleted the AP1929 branch July 15, 2022 01:54
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 15, 2022
JustZacca pushed a commit that referenced this pull request Jul 15, 2022
* feat(scroll): show scrollbar on hover only

* fix(scroll): switch to class option and apply to friends sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants