Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): phantom integration on the Iridium-dev #4012

Merged
merged 8 commits into from
Jul 21, 2022

Conversation

JustZacca
Copy link
Contributor

@JustZacca JustZacca commented Jul 18, 2022

As the name implies, this PR introduces Phantom Wallet to the Satellite, allowing users to sign up and run Iridium with it.
This PR also modifies the classic initialization of Iridium.

Now, by connecting the external wallet and using the internal wallet, iridium starts by signing a message.

I corrected the tests that I could fix related to my PR, but according to Sara's new directives, I skipped non-working tests.

This PR is temporary, as much as it does its job, it is only a small part, as we still have to modify the store and part of the workflow.

@JustZacca JustZacca requested a review from iltumio July 18, 2022 13:50
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 18, 2022
@socket-security
Copy link

Socket Security Report

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
@toruslabs/eccrypto@1.1.8 (added) binding.gyp package.json via @solana/wallet-adapter-wallets@0.16.8, @solana/wallet-adapter-torus@0.11.14, @toruslabs/solana-embed@0.2.2, @toruslabs/base-controllers@2.2.3, @toruslabs/broadcast-channel@6.1.0
keccak@3.0.2 (added) binding.gyp package.json via @solana/wallet-adapter-wallets@0.16.8, @solana/wallet-adapter-torus@0.11.14, @toruslabs/solana-embed@0.2.2, @toruslabs/base-controllers@2.2.3, @toruslabs/broadcast-channel@6.1.0
keccak@3.0.2 (added) install package.json via @solana/wallet-adapter-wallets@0.16.8, @solana/wallet-adapter-torus@0.11.14, @toruslabs/solana-embed@0.2.2, @toruslabs/base-controllers@2.2.3, @toruslabs/broadcast-channel@6.1.0
secp256k1@3.8.0 (added) install package.json via @solana/wallet-adapter-wallets@0.16.8, @solana/wallet-adapter-torus@0.11.14, @toruslabs/solana-embed@0.2.2, @toruslabs/base-controllers@2.2.3, @toruslabs/broadcast-channel@6.1.0, @toruslabs/eccrypto@1.1.8
@toruslabs/eccrypto@1.1.8 (added) install package.json via @solana/wallet-adapter-wallets@0.16.8, @solana/wallet-adapter-torus@0.11.14, @toruslabs/solana-embed@0.2.2, @toruslabs/base-controllers@2.2.3, @toruslabs/broadcast-channel@6.1.0
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Package Location
@toruslabs/eccrypto@1.1.8 (added) package.json via @solana/wallet-adapter-wallets@0.16.8, @solana/wallet-adapter-torus@0.11.14, @toruslabs/solana-embed@0.2.2, @toruslabs/base-controllers@2.2.3, @toruslabs/broadcast-channel@6.1.0
keccak@3.0.2 (added) package.json via @solana/wallet-adapter-wallets@0.16.8, @solana/wallet-adapter-torus@0.11.14, @toruslabs/solana-embed@0.2.2, @toruslabs/base-controllers@2.2.3, @toruslabs/broadcast-channel@6.1.0
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 5 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ⚠️ 2 new native modules detected

Powered by socket.dev

Copy link
Contributor

@aewing aewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!

Copy link
Contributor

@WanderingHogan WanderingHogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so neat

@aewing aewing merged commit 54dd8e8 into iridium-dev Jul 21, 2022
@aewing aewing deleted the Iridium-Phantom branch July 21, 2022 00:35
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA iridium labels Jul 21, 2022
@JustZacca
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants