-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): phantom integration on the Iridium-dev #4012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
A Dev and a Dev Approver need to review the PR, then mark as Ready for QA
label
Jul 18, 2022
aewing
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!!!
WanderingHogan
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so neat
github-actions
bot
removed
Missing Dev Review
A Dev and a Dev Approver need to review the PR, then mark as Ready for QA
iridium
labels
Jul 21, 2022
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name implies, this PR introduces Phantom Wallet to the Satellite, allowing users to sign up and run Iridium with it.
This PR also modifies the classic initialization of Iridium.
Now, by connecting the external wallet and using the internal wallet, iridium starts by signing a message.
I corrected the tests that I could fix related to my PR, but according to Sara's new directives, I skipped non-working tests.
This PR is temporary, as much as it does its job, it is only a small part, as we still have to modify the store and part of the workflow.