Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings/keybinds): update key press logic #4029

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

jasonwoodland
Copy link
Contributor

What this PR does πŸ“–

  • Uses an object to map key codes to the physical key being pressed
  • Fixes spaces showing up as blank keys
  • Fixes key input issue on macOS when using Option modifier
  • Adds a11y support for keyboard access

Which issue(s) this PR fixes πŸ”¨
AP-1998

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 21, 2022
@Satellite-im Satellite-im deleted a comment from github-actions bot Jul 21, 2022
@molimauro molimauro merged commit d071522 into iridium-dev Jul 21, 2022
@molimauro molimauro deleted the AP1998 branch July 21, 2022 14:59
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA iridium-dev labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants