Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): add settings mobile page with swiper functionality #4111

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Aug 2, 2022

What this PR does πŸ“–

  • consolidate settings render store values (showSidebar && settingsRoute). just render if settingsRoute has value
  • move styles from base.less into component
  • consolidate AsideMenu component into SettingsSidebar. It was probably intended to be generic, but became very specialized. simpler to combine them
  • remove unused mutations and store values in 'ui'
  • render mobile settings as a separate page rather than modal. still takes advantage of the same modal code (page components)

Which issue(s) this PR fixes πŸ”¨
AP-1885

Special notes for reviewers πŸ—’οΈ

  • it's not exactly perfect yet, but its better than before

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 2, 2022
@josephmcg josephmcg merged commit 1b6ff03 into iridium-dev Aug 3, 2022
@josephmcg josephmcg deleted the AP1885 branch August 3, 2022 06:28
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA iridium-dev labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants