Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): friends page #4131

Merged
merged 3 commits into from
Aug 5, 2022
Merged

feat(mobile): friends page #4131

merged 3 commits into from
Aug 5, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Aug 5, 2022

What this PR does πŸ“–

  • mobile layout for friends page implementing swiper, rather than multiple pages
  • delete legacy pages

Which issue(s) this PR fixes πŸ”¨
AP-2035

Special notes for reviewers πŸ—’οΈ

  • text needs styling, but I would like to build a better text component first
  • everything is missing functionality, this is just a start for the layout

https://www.figma.com/file/AwWgkAtjRDfVJlxpMbBbgP/Messenger?node-id=88%3A2789

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 5, 2022
Copy link
Contributor

@nathan-power nathan-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pages/mobile/friends/index.vue Show resolved Hide resolved
@nathan-power nathan-power merged commit 3a10197 into iridium-dev Aug 5, 2022
@nathan-power nathan-power deleted the AP2035 branch August 5, 2022 02:20
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA iridium-dev labels Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants