Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): render and store incoming messages #4137

Merged
merged 5 commits into from
Aug 5, 2022
Merged

feat(chat): render and store incoming messages #4137

merged 5 commits into from
Aug 5, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Aug 5, 2022 •
edited
Loading

What this PR does 📖

  • switch to object only message storage. experimented with an array too so it wouldn't need to be sorted, but that was complicated.
  • publish entire message payload and then store for recipient. this is a temporary solution while Drew investigates the CID load method

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

  • previous messages don't have an id attached to the payload. they will render strangely

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 5, 2022
@aewing aewing merged commit bca00fe into iridium-dev Aug 5, 2022
@aewing aewing deleted the chatFix branch August 5, 2022 15:05
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aewing aewing aewing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josephmcg @aewing