Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webrtc): restored with iridium #4188

Merged
merged 44 commits into from
Aug 10, 2022
Merged

feat(webrtc): restored with iridium #4188

merged 44 commits into from
Aug 10, 2022

Conversation

molimauro
Copy link
Contributor

@molimauro molimauro commented Aug 10, 2022

What this PR does πŸ“–
Restore basic webrtc communication:

  • audio/video calls
  • typing indicator

Which issue(s) this PR fixes πŸ”¨
AP-1966

Special notes for reviewers πŸ—’οΈ
I merged iridium-dev due to the high numbers of updates that went in meanwhile

Additional comments 🎀
connect/disconnect/discovery events are not working properly due to some iridium problems, but you can still call etc

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 10, 2022
@github-actions
Copy link
Contributor

⚠️ The title of this PR is invalid.
Please make the title match this format <type>(<scope>): <description>.
e.g.)
add(cli): enable --verbose flag
fix(api): avoid unexpected error in handler

allowed types - add, update, task, chore, feat, test, fix

@stavares843 stavares843 changed the title Iridium calls feat(calls): iridium calls Aug 10, 2022
@molimauro molimauro changed the title feat(calls): iridium calls feat(webrtc): restored with iridium Aug 10, 2022
@molimauro molimauro merged commit 8ca3a03 into iridium-dev Aug 10, 2022
@molimauro molimauro deleted the iridium-calls branch August 10, 2022 14:59
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 10, 2022
josephmcg added a commit that referenced this pull request Aug 12, 2022
josephmcg added a commit that referenced this pull request Aug 12, 2022
@josephmcg josephmcg restored the iridium-calls branch August 12, 2022 02:16
@stavares843 stavares843 deleted the iridium-calls branch August 16, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants