feat(notifications): notification basics #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
aewing
approved these changes
Aug 16, 2022
stavares843
reviewed
Aug 16, 2022
I didn't mess with that file, should I just delete the file altogether you think? |
|
notifications work 🎉
|
stavares843
added
the
Changes Requested
|
@Jekrimo can you delete that lock file and add pnpm-lock.yaml to the gitignore |
stavares843
reviewed
Aug 16, 2022
ran it, can we leave the commented out stuff? It'll be uncommented once we get images workin |
stavares843
reviewed
Aug 16, 2022
|
sounds good, thanks @Jekrimo 🔨 |
stavares843
removed
the
Changes Requested
aewing
removed
the
Missing Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Set up basics for notifications implementation
Which issue(s) this PR fixes 🔨
AP-1981