Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calls): background banner #4357

Merged
merged 2 commits into from
Aug 18, 2022
Merged

feat(calls): background banner #4357

merged 2 commits into from
Aug 18, 2022

Conversation

molimauro
Copy link
Contributor

What this PR does 📖

  • adds back the top app banner when moving away from the chat page
  • refactor some of the components and centralized most of the call logic into hooks for better concistency

Which issue(s) this PR fixes 🔨
AP-2174

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 18, 2022
@WanderingHogan WanderingHogan merged commit dce1150 into dev Aug 18, 2022
@WanderingHogan WanderingHogan deleted the AP2174 branch August 18, 2022 22:50
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@molimauro @WanderingHogan