Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal): close on 'Escape' key #4433

Merged
merged 5 commits into from
Aug 26, 2022
Merged

feat(modal): close on 'Escape' key #4433

merged 5 commits into from
Aug 26, 2022

Conversation

nathan-power
Copy link
Contributor

What this PR does 📖

Which issue(s) this PR fixes 🔨
AP-2226

Special notes for reviewers 🗒️

Additional comments 🎤

@nathan-power nathan-power self-assigned this Aug 24, 2022
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 24, 2022
@josephmcg
Copy link
Contributor

needs to play nicely with esc as a way of canceling current keybind entry

@josephmcg josephmcg added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Aug 24, 2022
@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Aug 26, 2022
@josephmcg josephmcg added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Aug 26, 2022
@jasonwoodland jasonwoodland added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Aug 26, 2022
@nathan-power
Copy link
Contributor Author

@jasonwoodland
Looks good! Not super high priority but if there are modals inside other modals the esc key closes both (e.g. the cropper picker modal inside of the profile settings modal)

@josephmcg josephmcg merged commit fe15bd2 into dev Aug 26, 2022
@josephmcg josephmcg deleted the AP-2226 branch August 26, 2022 07:03
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmcg josephmcg josephmcg approved these changes

Assignees

@nathan-power nathan-power

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nathan-power @josephmcg @jasonwoodland @stavares843