Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webrtc): initialize webrtc streams with user selected devices #4457

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

nathan-power
Copy link
Contributor

What this PR does πŸ“–

  • Initiates WebRTCManager state with user selected audioIn and videoIn devices.
  • Updates WebRTCManager state when user selected audioIn and videoIn devices change.
  • Initiates calls with user selected audioIn and videoIn devices using WebRTCManager state.

Which issue(s) this PR fixes πŸ”¨
AP-2231

Special notes for reviewers πŸ—’οΈ

  • This PR is outside the scope of switching audio/video stream devices while call is active. Switching devices during active calls will be implemented in a separate future PR.

Additional comments 🎀

@nathan-power nathan-power self-assigned this Aug 25, 2022
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 25, 2022
@molimauro molimauro merged commit 6909b4b into dev Aug 25, 2022
@molimauro molimauro deleted the AP-2231 branch August 25, 2022 08:22
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 25, 2022
@molimauro
Copy link
Contributor

Nice!! πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants