Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calls): reposition call controls #4465

Merged
merged 2 commits into from
Aug 25, 2022
Merged

feat(calls): reposition call controls #4465

merged 2 commits into from
Aug 25, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Aug 25, 2022 •
edited
Loading

What this PR does 📖

  • organize call controls so theyre better positioned. the modern convention for fullscreen toggle is the bottom right. may as well put the other buttons there too since most websites do. We want a familiar UI
  • remove cog button because it doesnt do anything

Which issue(s) this PR fixes 🔨
AP-2240

Special notes for reviewers 🗒️

  • the volume components are a bit tangled. settings uses the same volume component with a call, but greatly transforms it with props. kinda weird

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 25, 2022
@josephmcg josephmcg merged commit 256c99a into dev Aug 25, 2022
@josephmcg josephmcg deleted the AP2240 branch August 25, 2022 06:11
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@josephmcg