feat(welcome): welcome popup functioning and prelim copy #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
josephmcg
suggested changes
Sep 7, 2022
josephmcg
added
Changes Requested
stavares843
added
the
Missing Dev Review
github-actions
bot
added
the
missing fixing conflict
josephmcg
removed
the
Missing Dev Review
|
I fixed this for now, but in the future try putting the pound directly next to the issue number in the description. It wasn't getting hooked up to the issue properly |
WanderingHogan
added
Ready for QA
phillsatellite
approved these changes
Sep 9, 2022
github-actions
bot
removed
the
Ready for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Create new Welcome Popup that explains notable things about the app like where to find permissions and a warning that we are in EA
Which issue(s) this PR fixes 🔨
Resolve #4559
Special notes for reviewers 🗒️
I just put in first thoughts for what to have for the copy. Let me know anything we would like added or anything like that.