Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sidebar): add context call option #4640

Merged
merged 1 commit into from
Sep 7, 2022
Merged

feat(sidebar): add context call option #4640

merged 1 commit into from
Sep 7, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Sep 7, 2022 •
edited
Loading

What this PR does 📖

  • refactor some of the context menu markup
  • add sidebar calling if other user is online
  • remove send message from context menu since that's what left click does. it was redundant
  • hide quick profile until we can built it out more effectively

Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒️

  • I'd like to switch sidebarListItem to composition API, but it would be fairly involved
  • This work makes me realize I should switch text component to use color type 'danger' instead of error to fit the rest of the app

Additional comments 🎤

@josephmcg josephmcg linked an issue Sep 7, 2022 that may be closed by this pull request
add sidebar calling #4639
Closed
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 7, 2022
@WanderingHogan
Copy link
Contributor

lit

@WanderingHogan WanderingHogan added ready to merge and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Sep 7, 2022
@WanderingHogan WanderingHogan merged commit 2af381e into dev Sep 7, 2022
@WanderingHogan WanderingHogan deleted the sidebarCalling branch September 7, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WanderingHogan WanderingHogan WanderingHogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add sidebar calling
2 participants
@josephmcg @WanderingHogan