feat(pip): use animation keyframe #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
|
LGTM! Did you try this on Safari? If yes we can merge ;) |
molimauro
approved these changes
Sep 8, 2022
WanderingHogan
added
Ready for QA
|
@phillsatellite can you merge this if it works on safari, and can you test on mobile and make a note here if there is an issue |
phillsatellite
deleted the
4668-use-requestanimationframe-for-pip-animations
branch
github-actions
bot
removed
the
Ready for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨
Resolve #4668
Special notes for reviewers 🗒️
Additional comments 🎤