Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chatbar): replies style and focus on reply AP-155 #468

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

molimauro
Copy link
Contributor

What this PR does 📖

  • Fix a style bug on the chatbar when a reply is in place;
  • Remove a reply when switching conversations;
  • Does not persist the reply in the store;
  • Focus the chatbar when hitting reply.

Which issue(s) this PR fixes 🔨
JIRA: AP-155

Special notes for reviewers 🗒️

Additional comments 🎤
We should persist the replies when switching conversations but this needs a refactor in the way we store replies. Please open a ticket to keep track of this, thanks!

@InfamousVague InfamousVague added the Ready for QA Ready for QA team to test, Devs approved. label Dec 6, 2021
@stavares843 stavares843 added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Dec 6, 2021
@stavares843 stavares843 removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Dec 6, 2021
@stavares843 stavares843 changed the title fix(chatbar): replies style and focus on reply fix(chatbar): replies style and focus on reply AP-155 Dec 6, 2021
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove a reply when switching conversations - this one still happens

Screen.Recording.2021-12-06.at.5.19.45.PM.mp4

rest seems good 🎨

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Dec 6, 2021
Copy link
Contributor

@WanderingHogan WanderingHogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sara's change, then good

@molimauro
Copy link
Contributor Author

Updated! Thanks for noticing

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Dec 7, 2021
@WanderingHogan WanderingHogan added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Dec 7, 2021
@stavares843 stavares843 merged commit 4858bca into dev Dec 7, 2021
@stavares843 stavares843 deleted the bugfix_chatbar_reply branch December 7, 2021 21:12
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Dec 7, 2021
@stavares843
Copy link
Member

phil added a ticket for what you mentioned regarding

We should persist the replies when switching conversations but this needs a refactor in the way we store replies. Please open a ticket to keep track of this, thanks!

AP-235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants