Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): file uploads and downloads #4692

Merged
merged 5 commits into from
Sep 10, 2022
Merged

feat(chat): file uploads and downloads #4692

merged 5 commits into from
Sep 10, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Sep 9, 2022 •
edited
Loading

What this PR does 📖

  • check discord iridium channel for iridium env value
  • I didn't understand the significance of the safe boolean on the message. Feel free to adjust that part
  • move nsfw boolean setting to image container rather than spreading it all over the app

Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@josephmcg josephmcg marked this pull request as draft September 9, 2022 03:00
@josephmcg josephmcg added the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Sep 9, 2022
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 9, 2022
@josephmcg josephmcg removed the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Sep 9, 2022
@josephmcg josephmcg marked this pull request as ready for review September 9, 2022 06:43
@josephmcg josephmcg changed the title feat(files): upload wip feat(chat): file uploads and downloads Sep 9, 2022
@josephmcg josephmcg linked an issue Sep 9, 2022 that may be closed by this pull request
Hook up file uploads #4688
Closed
@josephmcg josephmcg force-pushed the iridiumFileUploads branch 2 times, most recently from 9896be7 to fda9c65 Compare September 9, 2022 09:27
@WanderingHogan
Copy link
Contributor

added a real quick and dirty block to sending if you are actively sending files, we should remove this later, hide the upload box, give feedback that the file is uploading, but still allow message sending while the file processes
Screen Shot 2022-09-09 at 7 03 38 PM
Screen Shot 2022-09-09 at 7 03 42 PM

@WanderingHogan WanderingHogan merged commit d20077a into dev Sep 10, 2022
@WanderingHogan WanderingHogan deleted the iridiumFileUploads branch September 10, 2022 01:25
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WanderingHogan WanderingHogan WanderingHogan approved these changes

@jasonwoodland jasonwoodland jasonwoodland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hook up file uploads
3 participants
@josephmcg @WanderingHogan @jasonwoodland