Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): lock scroll to bottom of chat #4712

Merged
merged 6 commits into from
Sep 12, 2022
Merged

feat(chat): lock scroll to bottom of chat #4712

merged 6 commits into from
Sep 12, 2022

Conversation

jasonwoodland
Copy link
Contributor

@jasonwoodland jasonwoodland commented Sep 12, 2022 •
edited
Loading

What this PR does 📖

  • If the chat is at the bottom, scroll it to the bottom when the dom mutates

Which issue(s) this PR fixes 🔨

Resolve #4128

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 12, 2022
@josephmcg
Copy link
Contributor

something to consider while using reverse
https://developer.mozilla.org/en-US/docs/Web/CSS/flex-direction#accessibility_concerns

@josephmcg josephmcg merged commit 2aee794 into dev Sep 12, 2022
@josephmcg josephmcg deleted the 4128-scroll-chat-from-bottom branch September 12, 2022 06:08
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmcg josephmcg josephmcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AP-2052: Scroll chat from bottom
2 participants
@jasonwoodland @josephmcg