-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(homeIconOnFiles): adjust home icon down to avoid icon clash #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WanderingHogan That sounds like a good suggestion, will look into implementing it! |
Functionality looks good! Small refactor request.. It seems like this was formatted using eslint rather than prettier, is that because of husky? You can configure prettier to format files on save so you don't have to think about it. In this case, I think the template literals ( |
yes husky is using we added the |
@josephmcg added that here |
@josephmcg Thank you so much for explaining how to clean up the classes in files.vue + have my code format to Prettier on save! |
@stavares843 It could be used to dynamically set attributes Thanks for checking! |
thanks for clarifying! π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Kat
What this PR does π
https://satellite-im.atlassian.net/browse/AP-156
Which issue(s) this PR fixes π¨
Fixes #
Special notes for reviewers ποΈ
Additional comments π€