fix(chat): send message after store&publish #4901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
WanderingHogan
force-pushed
the
fix_chat_send
branch
from
9c7a61e
to
0d582b0
Compare
WanderingHogan
approved these changes
Sep 19, 2022
|
good idea |
WanderingHogan
added
Ready for QA
stavares843
force-pushed
the
fix_chat_send
branch
from
0d582b0
to
f521efc
Compare
|
not saying this is from the PR just to be informative (even though prod has/had a similar bug) this PR
we did the same on core and i was able to get the messages from the other users + they were on the group list as well note
|
|
i've seen that other bug on prod before and think it's unrelated, this should take care of the issue where you can send things and see it on one side, reload, and then not see it on the other because iridium didn't receive it yet |
|
fine by me i also saw a similar one on prod that i added above but adding this just for info 😂 |
stavares843
added
merge-or-not-merge
and removed
Ready for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤