Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest): increase coverage for time utilities #4903

Merged
merged 3 commits into from
Sep 20, 2022
Merged

feat(jest): increase coverage for time utilities #4903

merged 3 commits into from
Sep 20, 2022

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Sep 16, 2022 •
edited
Loading

What this PR does πŸ“–

100% coverage for utilities/Timezone
88% coverage for utilities/duration

Which issue(s) this PR fixes πŸ”¨

Ticket: AP-2691

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 16, 2022
@stavares843 stavares843 changed the title feat(jest): increaes coverage for time utilities feat(jest): increase coverage for time utilities Sep 16, 2022
stavares843
stavares843 requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2022-09-16, às 17 48 36

this fails locally

works on CI but fails locally

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Sep 16, 2022
@drepram
Copy link
Contributor Author

drepram commented Sep 19, 2022

Captura de ecrã 2022-09-16, às 17 48 36

this fails locally

works on CI but fails locally

Okay, I will try to change the city today

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Sep 19, 2022
@stavares843
Copy link
Member

Captura de ecrã 2022-09-19, às 14 21 38

still fails locally

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Sep 19, 2022
@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Sep 20, 2022
@stavares843 stavares843 merged commit 1d89e61 into dev Sep 20, 2022
@stavares843 stavares843 deleted the drepram/improve-time-utilities branch September 20, 2022 16:16
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jekrimo Jekrimo Jekrimo approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drepram @stavares843 @Jekrimo