fix(signin-loading): removed auth middleware

[ThomBos]

What this PR does 📖

• fixes "forever linking" issue

Which issue(s) this PR fixes 🔨

• Resolve Add timeout to 'linking satellites' #4933

Special notes for reviewers 🗒️

Additional comments 🎤

[stavares843]

since the last deploy i haven't had that linking issue

[stavares843]

when using this PR, it goes right away to this page, instead of the create account view

and then if you try to create an account, it returns an error because the user didn't have the previous view to setup a PIN

[stavares843]

can we reuse the same logic we did here instead? when we were using solana, we added a modal that would appear after 30s, can we reuse that but for the nodes timeout?

[ThomBos]

when using this PR, it goes right away to this page, instead of the create account view

and then if you try to create an account, it returns an error because the user didn't have the previous view to setup a PIN

oh yeah, didn't noticed when refreshing, this happens the first time you open the app.
i'm on it

[stavares843]

is this ready to review again? @ThomBos 🔨

[ThomBos]

is this ready to review again? @ThomBos 🔨

yes, check if you see any issue 👍

[ThomBos]

Is there a way we could approach more simply that doesn't spread copy pasted code across so many different components?

Perhaps adding a check on the Global.vue component (which is rendered in desktop and mobile layouts. we can add it to default as well). It could determine if iridium is ready on mount, then kick the user back to the main login page if they aren't on another auth page

Everytime we call "loadaccount" the catch is necessary, that's why that pasted code can't be removed. Maybe making changes on Global.vue allows code to be removed from layouts components 👍

[molimauro]

Why do we want to ditch the middleware? Any particular reason?

[ThomBos]

Why do we want to ditch the middleware? Any particular reason?

@aewing was it to make it more simple, or you had something to integrate?

[ThomBos]

Is there a way we could approach more simply that doesn't spread copy pasted code across so many different components?

Perhaps adding a check on the Global.vue component (which is rendered in desktop and mobile layouts. we can add it to default as well). It could determine if iridium is ready on mount, then kick the user back to the main login page if they aren't on another auth page

Can tell you it didn't change when putting this code in Global.vue

[aewing]

Why do we want to ditch the middleware? Any particular reason?

We see some strange redirect loops and errors with the middleware approach. I think throwing a catch-all solution at this isn't necessarily the answer. We should be able to implement a view on the homepage (/) that checks for stored pin & attempts to restore, failing that it could redirect to the import/create account screen, which can redirect to profile entry if one isn't present. We shouldn't need to globally check state every time it changes if we think about when to redirect the user in the UI.

[ThomBos]

Why do we want to ditch the middleware? Any particular reason?

We see some strange redirect loops and errors with the middleware approach. I think throwing a catch-all solution at this isn't necessarily the answer. We should be able to implement a view on the homepage (/) that checks for stored pin & attempts to restore, failing that it could redirect to the import/create account screen, which can redirect to profile entry if one isn't present. We shouldn't need to globally check state every time it changes if we think about when to redirect the user in the UI.

What if the user doesn't enter the homepage? (like he enters "/chat/xyz" directly in the url)

[molimauro]

I think we should consider closing this one and:

• introducing a timeout for the signin starting from what we have in dev
• keep the middleware (its purpose is to run before every page so more reliable then a custom one) but refactor it since it is based on a old logic

Let me know your thoughts!

[josephmcg]

yeah it seems like we could write some middleware that checks your current route + iridium status and knocks back appropriately.

According to the doc it runs before render
https://nuxtjs.org/docs/directory-structure/middleware/

[ThomBos]

I think we should consider closing this one and:

• introducing a timeout for the signin starting from what we have in dev
• keep the middleware (its purpose is to run before every page so more reliable then a custom one) but refactor it since it is based on a old logic

Let me know your thoughts!

I agree, removing middleware takes too much work to get the same behaviour and isn't as reliable (at least with this code)

[molimauro]

Opened the tickets for those, closing this one