Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(error-network): fix undefined errors #4959

Merged
merged 2 commits into from
Sep 21, 2022
Merged

fix(error-network): fix undefined errors #4959

merged 2 commits into from
Sep 21, 2022

Conversation

nathan-power
Copy link
Contributor

What this PR does 📖

  • "tryAgain" and "$t" were returning undefined

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@nathan-power nathan-power added this to the UI milestone Sep 21, 2022
@nathan-power nathan-power self-assigned this Sep 21, 2022
@nathan-power nathan-power linked an issue Sep 21, 2022 that may be closed by this pull request
Error modal fix #4952
Closed
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 21, 2022
@josephmcg josephmcg merged commit c6710e8 into dev Sep 21, 2022
@josephmcg josephmcg deleted the 4952-error-modal-fix branch September 21, 2022 06:56
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA bug labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwoodland jasonwoodland jasonwoodland approved these changes

@josephmcg josephmcg josephmcg approved these changes

Assignees

@nathan-power nathan-power

Labels
None yet
Projects
None yet
Milestone
UI
Development

Successfully merging this pull request may close these issues.

Error modal fix
3 participants
@nathan-power @jasonwoodland @josephmcg