fix(files): fix table layout for small screens #4967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
phillsatellite
approved these changes
Sep 21, 2022
phillsatellite
added
the
QA tested
josephmcg
force-pushed
the
4966-fix-table-layout-for-small-screens
branch
from
d6a20df
to
95cef91
Compare
josephmcg
approved these changes
Sep 22, 2022
Comment on lines
+40
to
+62
| <div v-else-if="gridLayout" class="files-view__desktop-wrapper"> | ||
| <FilesGrid | ||
| :directory="directory" | ||
| @like="like" | ||
| @share="share" | ||
| @rename="rename" | ||
| @remove="remove" | ||
| @handle="handle" | ||
| class="files-view-desktop" | ||
| /> | ||
| </div> | ||
|
|
||
| <div v-else-if="!gridLayout" class="files-view__desktop-wrapper"> | ||
| <FilesList | ||
| :directory="directory" | ||
| @like="like" | ||
| @share="share" | ||
| @rename="rename" | ||
| @remove="remove" | ||
| @handle="handle" | ||
| class="files-view-desktop" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
this markup could probably be simplified, but later is ok
github-actions
bot
removed
Missing Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤