Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user): fix users offline status delay #4973

Merged
merged 1 commit into from
Sep 22, 2022
Merged

fix(user): fix users offline status delay #4973

merged 1 commit into from
Sep 22, 2022

Conversation

maljuburi
Copy link
Contributor

@maljuburi maljuburi commented Sep 21, 2022

Adds a listener for the stopping event for IridiumManager. to fix an offline messages issue

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 21, 2022
@WanderingHogan WanderingHogan changed the base branch from main to dev September 21, 2022 23:22
@stavares843
Copy link
Member

Captura de ecrã 2022-09-22, às 00 23 18

and yes all PR's should point to dev and not main

@maljuburi
Copy link
Contributor Author

closing because we decided to release on Friday

Captura de ecrã 2022-09-22, às 00 23 18

and yes all PR's should point to dev and not main

yes, we were on a call with Sheldon testing things in Prod.. that's why I thought we are hotfixing it :)

@stavares843
Copy link
Member

yes, we were on a call with Sheldon testing things in Prod.. that's why I thought we are hotfixing it :)

no, there's no hotfixing for this, we are gonna release later this week and will include all in one

@maljuburi maljuburi changed the title fix(manager): start iridium manager fix Fix issue some users had logging in, stuck in linking satellites state Sep 21, 2022
@github-actions
Copy link
Contributor

⚠️ The title of this PR is invalid.
Please make the title match this format <type>(<scope>): <description>.
e.g.)
add(cli): enable --verbose flag
fix(api): avoid unexpected error in handler

allowed types - add, update, task, chore, feat, test, fix

@maljuburi maljuburi changed the title Fix issue some users had logging in, stuck in linking satellites state fix(login): Fix issue some users had logging in, stuck in linking satellites state Sep 21, 2022
@maljuburi maljuburi changed the title fix(login): Fix issue some users had logging in, stuck in linking satellites state fix(user): Fix users offline status delay Sep 21, 2022
@stavares843 stavares843 changed the title fix(user): Fix users offline status delay fix(user): fix users offline status delay Sep 21, 2022
@maljuburi
Copy link
Contributor Author

yes, we were on a call with Sheldon testing things in Prod.. that's why I thought we are hotfixing it :)

no, there's no hotfixing for this, we are gonna release later this week and will include all in one

Yes, it was then communicated to me on Discord, but thanks

@WanderingHogan WanderingHogan merged commit accbf03 into dev Sep 22, 2022
@WanderingHogan WanderingHogan deleted the manager/fix branch September 22, 2022 02:07
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants