Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs): remove webkit autofill color #4981

Merged

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Sep 22, 2022

What this PR does πŸ“–

  • title

previously looked like this πŸ˜΅β€πŸ’«
image

Which issue(s) this PR fixes πŸ”¨

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@josephmcg josephmcg linked an issue Sep 22, 2022 that may be closed by this pull request
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 22, 2022
@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Sep 22, 2022
@stavares843
Copy link
Member

neat πŸŽ‰

chrome is fixed

before on safari was yellow

image

vs this PR

image

better, still needs some fixing that we can do later, not important

and i also noticed that in firefox, even though not from the PR but just adding that info in case you wanna fix it later, when you first generate a pw to auto fill, it shows the pw instead of being masked

Gravacao.do.ecra.2022-09-22.as.18.02.46.mov

image

how it should be

Captura de ecrã 2022-09-22, às 18 06 06

@phillsatellite phillsatellite added ready to merge and removed Ready for QA Ready for QA team to test, Devs approved. labels Sep 22, 2022
@stavares843 stavares843 merged commit b080a7a into dev Sep 22, 2022
@stavares843 stavares843 deleted the 4980-remove-chrome-password-autofill-white-background branch September 22, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove chrome password autofill white background
4 participants