Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): improve a11y around input component #5133

Merged
merged 3 commits into from Oct 4, 2022
Merged

fix(input): improve a11y around input component #5133

merged 3 commits into from Oct 4, 2022

Conversation

josephmcg
Copy link
Contributor

What this PR does 📖

  • move accessibility outline to outer input border (wraps button and appends too, similar to chatbar)
  • prevent outline on autofocus inputs

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@josephmcg josephmcg linked an issue Oct 4, 2022 that may be closed by this pull request
improve accessibility around input component #5102
Closed
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Oct 4, 2022
@josephmcg josephmcg added the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Oct 4, 2022
@josephmcg josephmcg removed the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Oct 4, 2022
@josephmcg josephmcg merged commit 1ae90ac into dev Oct 4, 2022
@josephmcg josephmcg deleted the 5102-improve-accessibility-around-input-component branch October 4, 2022 01:47
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwoodland jasonwoodland jasonwoodland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve accessibility around input component
2 participants
@josephmcg @jasonwoodland