Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: char counter update on emoji - [AP-169] #625

Merged
merged 7 commits into from
Dec 16, 2021
Merged

fix: char counter update on emoji - [AP-169] #625

merged 7 commits into from
Dec 16, 2021

Conversation

KemoPaw
Copy link
Contributor

@KemoPaw KemoPaw commented Dec 14, 2021

What this PR does 📖

  • counter for char limit updates when adding emoji(s)
  • emoji(s) are counted as only one "length" instead of two

Which issue(s) this PR fixes 🔨
https://satellite-im.atlassian.net/browse/AP-169

Fixes #

Special notes for reviewers 🗒️

Additional comments 🎤

@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 14, 2021
stavares843
stavares843 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed ✅

@stavares843 stavares843 added the QA tested One QA Person has tested - Needs QA Lead review still label Dec 14, 2021
WanderingHogan
WanderingHogan suggested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@WanderingHogan WanderingHogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor updates to the Footer.vue file in the comments

@WanderingHogan WanderingHogan added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Dec 14, 2021
@stavares843 stavares843 changed the title [AP-169] - fix(emojiUpdateCharCounter): char counter update on emoji fix(emojiUpdateCharCounter): char counter update on emoji - [AP-169] Dec 14, 2021
@stavares843 stavares843 changed the title fix(emojiUpdateCharCounter): char counter update on emoji - [AP-169] fix: char counter update on emoji - [AP-169] Dec 14, 2021
@KemoPaw KemoPaw added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Dec 14, 2021
josephmcg
josephmcg approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@josephmcg josephmcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Dec 15, 2021
KemoPaw and others added 7 commits December 14, 2021 23:10
@KemoPaw @WanderingHogan
fix(emojiUpdateCharCounter): char counter update on emoji and emoji o…
9b1c0aa 
…nly one length
@KemoPaw @WanderingHogan
fix(emojiUpdateCharCounter): use lodash to count emoji chars
81c8892
@KemoPaw @WanderingHogan
fix(emojiUpdateCharCounter): code cleanup and refactoring for easy read
453ef8c
@WanderingHogan
feat(Alerts): added alerts (#627)
1aeefba 
* feat(Alerts): added alerts
also refactored a few things

* feat(Alerts): added alerts
also refactored a few things

* feat(Alerts): added alerts
also refactored a few things

* feat(Alerts): added alerts
also refactored a few things

* feat(Alerts): added alerts
also refactored a few things

* fix(Settings): fixed editing mock and tweak causing crash
@KemoPaw @WanderingHogan
fix(emojiUpdateCherCounter): code cleanup
5760fea
@KemoPaw @WanderingHogan
fix(emojiUpdateCherCounter): code rebase
44473ad
@KemoPaw @WanderingHogan
fix(emojiUpdateCharCounter): code cleanup and refactoring for easy read
0013691
@github-actions github-actions bot removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Dec 15, 2021
@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Dec 15, 2021
stavares843
stavares843 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! 🎉

@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Ready for QA Ready for QA team to test, Devs approved. labels Dec 15, 2021
@stavares843
Copy link
Member

added missing dev review label again because hogan was requested for review

@WanderingHogan WanderingHogan removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 15, 2021
@stavares843 stavares843 merged commit c615dad into dev Dec 16, 2021
@stavares843 stavares843 deleted the emojiUpdateCharCounter branch December 16, 2021 00:11
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WanderingHogan WanderingHogan WanderingHogan approved these changes

@Jekrimo Jekrimo Jekrimo approved these changes

@stavares843 stavares843 stavares843 approved these changes

@josephmcg josephmcg josephmcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KemoPaw @stavares843 @WanderingHogan @Jekrimo @josephmcg