Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webrtc): basic video and voice calling #640

Merged
merged 9 commits into from
Dec 22, 2021
Merged

feat(webrtc): basic video and voice calling #640

merged 9 commits into from
Dec 22, 2021

Conversation

jpanay
Copy link
Contributor

@jpanay jpanay commented Dec 14, 2021

What this PR does πŸ“–
Allows users to call each other with video and voice
Which issue(s) this PR fixes πŸ”¨

Fixes #

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 14, 2021
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2021-12-14, às 22 56 41

Captura de ecrã 2021-12-14, às 22 56 47

should we comment out the fullscreen until we address that better?

@jpanay
Copy link
Contributor Author

jpanay commented Dec 15, 2021

No need to comment it out because I'm going to continue to work on calling and bugs like this after this pull gets merged

@stavares843
Copy link
Member

ohh k thanks for clarifying! neat πŸŽ‰

@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Dec 15, 2021
@iltumio
Copy link
Collaborator

iltumio commented Dec 16, 2021

It is not working for me

@jpanay
Copy link
Contributor Author

jpanay commented Dec 17, 2021

It is not working for me

I just pulled dev and a bunch of files were moved around and cleared some work I did so that might be it, also fixing it now

@github-actions github-actions bot removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Dec 17, 2021
components/tailored/core/incomingCall/IncomingCall.html Outdated Show resolved Hide resolved
components/tailored/core/incomingCall/IncomingCall.html Outdated Show resolved Hide resolved
components/tailored/core/media/Media.html Outdated Show resolved Hide resolved
components/tailored/core/media/actions/Actions.html Outdated Show resolved Hide resolved
components/tailored/core/statusbar/Statusbar.html Outdated Show resolved Hide resolved
components/tailored/core/statusbar/Statusbar.html Outdated Show resolved Hide resolved
components/tailored/core/statusbar/Statusbar.vue Outdated Show resolved Hide resolved
components/ui/Global/Global.html Outdated Show resolved Hide resolved
components/ui/Global/Global.html Show resolved Hide resolved
store/webrtc/actions.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Dec 19, 2021
@InfamousVague InfamousVague merged commit 61f7acd into dev Dec 22, 2021
@InfamousVague InfamousVague deleted the video-chat branch December 22, 2021 06:36
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants