Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Emoji): make emoji's bigger and better #649

Merged
merged 6 commits into from
Dec 16, 2021
Merged

feat(Emoji): make emoji's bigger and better #649

merged 6 commits into from
Dec 16, 2021

Conversation

InfamousVague
Copy link

What this PR does 📖
image

@InfamousVague InfamousVague added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 15, 2021
@@ -1,9 +1,6 @@
@import '../VideoPlayer/VideoPlayer.less';


.iframe-video-container {
Copy link
Author

@InfamousVague InfamousVague Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing every message, even those without a video, to have extra padding. so I nuked it.
image

@KemoPaw
Copy link
Contributor

KemoPaw commented Dec 15, 2021

Looking snazzy! :)

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Dec 15, 2021
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! 🎉

but seems the animation gets a bit stuck especially with a bunch of emojis

is this something we want to improve?

Screen.Recording.2021-12-15.at.1.21.49.PM.mp4

Chrome, macOS

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Dec 15, 2021
@stavares843 stavares843 merged commit d9a7406 into dev Dec 16, 2021
@stavares843 stavares843 deleted the emoji branch December 16, 2021 00:32
@github-actions github-actions bot removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants