Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache): use service worker to cache ipfs responses #752

Merged
merged 3 commits into from
Dec 22, 2021
Merged

feat(cache): use service worker to cache ipfs responses #752

merged 3 commits into from
Dec 22, 2021

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Dec 22, 2021 •
edited
Loading

What this PR does 📖

  • service worker caches ipfs responses like glyphs and mute/deafen/video mp3
  • using StaleWhileRevalidate since ipfs sends opaque responses. If we enable CORS on ipfs, we could look into cacheFirst

Which issue(s) this PR fixes 🔨
N/A

Special notes for reviewers 🗒️
https://pwa.nuxtjs.org/workbox/#enabled

  • documentation recommends testing by running prod locally. I couldn't get that to work, so I just switch enabled to true in nuxt.config
  • you will need to check application tab of chrome dev tools to see details about service worker

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 22, 2021
iltumio
iltumio requested changes Dec 22, 2021
View reviewed changes
Copy link
Collaborator

@iltumio iltumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be rebased before merging

@iltumio
Copy link
Collaborator

iltumio commented Dec 22, 2021

what is the downside of keeping the enabled option set to true even running the app in localhost?

@stavares843 stavares843 merged commit b623c19 into dev Dec 22, 2021
@stavares843 stavares843 deleted the serviceWorker branch December 22, 2021 16:28
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

@iltumio iltumio iltumio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josephmcg @iltumio @stavares843