feat(Friends): combine friends routes #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfamousVague
requested review from
genie-magic,
molimauro and
Legendarydeva
github-actions
bot
added
the
Missing Dev Review
InfamousVague
commented
Dec 25, 2021
| // status: 'Reeeeeeeee', | ||
| // state: 'online', | ||
| // }, | ||
| { |
There was a problem hiding this comment.
Just a note here, if we want to not use mock content we should add a real placeholder in state, this way mock data can still be used in tests, instead of being commented out.
There was a problem hiding this comment.
This is why I've uncommented.
Jekrimo
approved these changes
Dec 26, 2021
molimauro
approved these changes
Dec 27, 2021
stavares843
approved these changes
Dec 27, 2021
github-actions
bot
removed
the
Missing Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 馃摉