Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Themes): added custom flair color selector #802

Merged
merged 4 commits into from
Dec 27, 2021
Merged

feat(Themes): added custom flair color selector #802

merged 4 commits into from
Dec 27, 2021

Conversation

InfamousVague
Copy link

@InfamousVague InfamousVague commented Dec 25, 2021 •
edited
Loading

What this PR does 馃摉

Allows user to choose custom flair color on some themes.
localhost_3000_(iPhone X) (14)

image

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 25, 2021
@InfamousVague InfamousVague changed the title Theme flair color feat(Themes): added custom flair color selector Dec 25, 2021
@github-actions
Copy link
Contributor

鈿狅笍 The title of this PR is invalid.
Please make the title match this format <type>(<scope>): <description>.
e.g.)
add(cli): enable --verbose flag
fix(api): avoid unexpected error in handler

allowed types - add, update, task, chore, feat, test, fix

@InfamousVague InfamousVague self-assigned this Dec 26, 2021
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Dec 27, 2021
@stavares843
Copy link
Member

Captura de ecra虄 2021-12-27, a虁s 20 07 23

profile > timezone > still shows the blue background when searching

@stavares843
Copy link
Member

Captura de ecra虄 2021-12-27, a虁s 20 07 33

should the cursor be matching the theme as well?

@stavares843
Copy link
Member

should the search/filter match the theme as well?

Captura de ecra虄 2021-12-27, a虁s 20 12 19

@stavares843
Copy link
Member

stavares843 commented Dec 27, 2021 •
edited
Loading

should the reply to match the theme as well?

Captura de ecra虄 2021-12-27, a虁s 20 13 42

@stavares843
Copy link
Member

Captura de ecra虄 2021-12-27, a虁s 20 14 02

should the border on the edit box match the theme?

@stavares843
Copy link
Member

Captura de ecra虄 2021-12-27, a虁s 20 14 33

when selecting text, should match the theme?

stavares843
stavares843 requested changes Dec 27, 2021
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty neat! 馃帀

added couple comments

@stavares843 stavares843 added the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Dec 27, 2021
@InfamousVague InfamousVague merged commit 6efbe05 into dev Dec 27, 2021
@InfamousVague InfamousVague deleted the theme-flair-color branch December 27, 2021 22:37
@github-actions github-actions bot removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa labels Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 requested changes

@Jekrimo Jekrimo Jekrimo approved these changes

@molimauro molimauro molimauro approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees

@InfamousVague InfamousVague

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@InfamousVague @stavares843 @Jekrimo @molimauro @phillsatellite