Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript fix on listing downloaded files via selenium #405

Merged
merged 1 commit into from Oct 9, 2019

Conversation

tstrych
Copy link
Contributor

@tstrych tstrych commented Oct 7, 2019

Automation failure correction of test_positive_export
https://github.com/SatelliteQE/robottelo/blob/master/tests/foreman/ui/test_host.py#L814

export automatically goes to browser where files[0] were empty and this cause an error later on.
https://github.com/SatelliteQE/airgun/blob/master/airgun/browser.py#L756

I looked into the JavaScript and it seems there can be also another option fileUrl.

============================= test session starts ==============================
collected 28 items / 27 deselected / 1 selected
============ 1 passed, 27 deselected, 2 warnings in 165.83 seconds =============

Copy link
Contributor

@mirekdlugosz mirekdlugosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had #323 opened a long time ago, but I like this approach a little better, as it keeps backwards compatibility with very old Chrome versions.

ACK

Copy link
Collaborator

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, +1 gives on to a backward compatibility

@tstrych
Copy link
Contributor Author

tstrych commented Oct 9, 2019

Can you @mirekdlugosz merge this ? I have two ACKs. I shoudn't merge it as I am not tier* reviewer for airgun.

@omkarkhatavkar omkarkhatavkar merged commit cf0b4d9 into SatelliteQE:master Oct 9, 2019
@tstrych tstrych mentioned this pull request Oct 9, 2019
@tstrych tstrych deleted the get_downloads_list branch February 17, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants