Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to selenium grid 4 needs upgrade in the version #663

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Upgrading to selenium grid 4 needs upgrade in the version #663

merged 1 commit into from
Feb 9, 2022

Conversation

omkarkhatavkar
Copy link
Collaborator

@omkarkhatavkar omkarkhatavkar commented Jan 25, 2022 •
edited
Loading

$subject

pip list | grep selenium
selenium 4.1.0
selenium-smart-locator 0.2.0
pip list | grep pattern
widgetastic.patternfly 1.3.4
widgetastic.patternfly4 0.23.2.dev2+gcb3bf05

swadeley
swadeley approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@swadeley swadeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@swadeley swadeley requested review from a team January 25, 2022 12:41
jyejare
jyejare reviewed Jan 27, 2022
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending question !

setup.py Outdated
@@ -21,7 +21,7 @@
'navmazing',
'python-box',
'pytest',
'selenium',
'selenium==4.1.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, selenium is being installed in the latest version, but you are trying to freeze this to a specific version! This comes an additional overhead of upgrading it every time to the suitable version!

Why not stick to the existing approach? Does selenium installs a different version than selenium 4 ?

Copy link
Collaborator Author

@omkarkhatavkar omkarkhatavkar Jan 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the latest version where I have tested it with the RedHat image. I think this will have not any value if I guess RedHatQE/widgetastic.patternfly4#128 PR get merged

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip list | grep selenium
selenium 4.1.0
selenium-smart-locator 0.2.0
pip list | grep pattern
widgetastic.patternfly 1.3.4
widgetastic.patternfly4 0.23.2.dev2+gcb3bf05

latran
latran approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@latran latran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@omkarkhatavkar omkarkhatavkar marked this pull request as draft January 28, 2022 13:14
@omkarkhatavkar omkarkhatavkar marked this pull request as ready for review February 7, 2022 09:25
@omkarkhatavkar omkarkhatavkar marked this pull request as draft February 7, 2022 11:17
@omkarkhatavkar omkarkhatavkar marked this pull request as ready for review February 9, 2022 14:29
@swadeley swadeley merged commit e1f9c93 into SatelliteQE:master Feb 9, 2022
omkarkhatavkar added a commit that referenced this pull request Feb 10, 2022
@omkarkhatavkar
Revert "upgrading the selenium version for selenium grid 4 (#663)"
75d577f 
This reverts commit e1f9c93.
@omkarkhatavkar omkarkhatavkar mentioned this pull request Feb 10, 2022
Closed
@swadeley swadeley mentioned this pull request Feb 10, 2022
Merged
latran pushed a commit to latran/airgun that referenced this pull request Feb 14, 2022
@omkarkhatavkar @latran
upgrading the selenium version for selenium grid 4 (SatelliteQE#663)
49efe73
tstrych added a commit to tstrych/airgun that referenced this pull request Feb 16, 2022
@tstrych
Revert "upgrading the selenium version for selenium grid 4 (Satellite…
9e05326 
…QE#663)"

This reverts commit e1f9c93.
latran pushed a commit to latran/airgun that referenced this pull request Feb 21, 2022
@omkarkhatavkar @latran
upgrading the selenium version for selenium grid 4 (SatelliteQE#663)
8a39540
synkd pushed a commit to synkd/airgun that referenced this pull request Mar 2, 2022
@omkarkhatavkar @synkd
upgrading the selenium version for selenium grid 4 (SatelliteQE#663)
84cc97f
JacobCallahan pushed a commit to JacobCallahan/airgun that referenced this pull request Mar 4, 2022
@omkarkhatavkar @JacobCallahan
upgrading the selenium version for selenium grid 4 (SatelliteQE#663)
684d447
mshriver pushed a commit that referenced this pull request Mar 7, 2022
@omkarkhatavkar @mshriver
upgrading the selenium version for selenium grid 4 (#663)
100fbb7
Griffin-Sullivan pushed a commit to latran/airgun that referenced this pull request Apr 20, 2023
@omkarkhatavkar @Griffin-Sullivan
upgrading the selenium version for selenium grid 4 (SatelliteQE#663)
8731cdc
Griffin-Sullivan pushed a commit to latran/airgun that referenced this pull request Apr 20, 2023
@omkarkhatavkar @Griffin-Sullivan
upgrading the selenium version for selenium grid 4 (SatelliteQE#663)
aab7c87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare left review comments

@latran latran latran approved these changes

@swadeley swadeley swadeley approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@omkarkhatavkar @latran @swadeley @jyejare @jameerpathan111