Skip to content

Commit

Permalink
Fix setup_proxy task
Browse files Browse the repository at this point in the history
In the previous refactor was checking for proxy username and password
being None to add the installer options. That is not right as we want to
set the username and password if they are not None.
  • Loading branch information
elyezer committed Mar 23, 2015
1 parent 489ec7b commit 195149a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions automation_tools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,9 @@ def setup_proxy(run_katello_installer=True):
'katello-proxy-url': 'http://{0}'.format(proxy_info.hostname),
'katello-proxy-port': proxy_info.port,
}
if proxy_info.username is None:
if proxy_info.username is not None:
installer_options['katello-proxy-username'] = proxy_info.username
if proxy_info.password is None:
if proxy_info.password is not None:
installer_options['katello-proxy-password'] = proxy_info.password
if run_katello_installer:
katello_installer(**installer_options)
Expand Down

0 comments on commit 195149a

Please sign in to comment.