Added new function to create a compose repo file #101

JacobCallahan · 2014-12-16T17:21:26Z

Requires the repo_url be passed in the command.

Example

fab -H ibm-x3550m3-12.lab.eng.brq.redhat.com -u root -p '******' add_repo:'test','http://porkchop.devel.redhat.com/released/RHEL-7/7.0/Server/x86_64/os/';
[ibm-x3550m3-12.lab.eng.brq.redhat.com] Executing task 'add_repo'
[ibm-x3550m3-12.lab.eng.brq.redhat.com] run: echo "[test]
name=test
baseurl=http://porkchop.devel.redhat.com/released/RHEL-7/7.0/Server/x86_64/os/
enabled=1
" >> automation-tools.repo

Adresses #72

elyezer · 2014-12-16T20:09:28Z

automation_tools/__init__.py

@@ -1157,6 +1157,18 @@ def performance_tuning(running_on_vm=True):
        run('tuned-adm profile throughput-performance')


+def generate_compose_repofile():


s/generate_compose_repofile/generate_compose_upgrade_repofile?

Or we can make this generic and expect the name and URL, so we can do something like

'[{0}]\n' '...' 'baseurl={1}\n' '...'.format(name, url)

i was thinking about making it general, but don't know if this function would be useful outside of installing a compose.

elyezer · 2014-12-16T20:13:41Z

ACK, pending comments.

cswiii · 2014-12-16T20:30:17Z

There could be namespace collision if we were, say, installing from compose, upgrading, and then trying to upgrade packages.

Using BASE_URL would work fine along the following path:

install_from_cdn generate_compose_repofile update packages

It might be more problematic if the initial install is from compose

Also generate_compose_repofile might be a bit long, but perhaps that's just me. If others are fine with it, I'm amenable.

cswiii · 2014-12-16T20:32:17Z

I this this function would be useful anyway, for future use. I'm wondering if there is a way to parameterize it so it could be use for base installs and/or upgrades? Or would that be icky?

JacobCallahan · 2014-12-16T20:38:39Z

what we could do is change the function to add_repofile and expect a REPO_URL environmental variable be passed. that way we have a generic function to add repo files whenever we want.

JacobCallahan · 2014-12-17T15:33:50Z

@elyezer @cswiii updated code and sanitized commit message.

elyezer · 2014-12-17T19:33:48Z

automation_tools/__init__.py

+            '[{0}]\n'
+            'name={0}\n'
+            'baseurl={1}\n'
+            'enabled=1\n'.format(urlsplit(repo_url).netloc, repo_url)


If we start using this function to setup the downstream repo then it could still conflict with the upgrade URL. We need a better way to handle the name of the repo.

yeah, that is becoming the tough part.. i am tempted just to generate a random string, but that would be messy.

Any update on this?

not yet. it is difficult to find a balance between something meaningful and something that won't be duplicated.

Accepting a name parameter, the user will choose the appropriate name.

yeah. we could do that and if no name is given, then use the domain name as the name.

elyezer · 2014-12-22T19:29:20Z

automation_tools/__init__.py

+            'enabled=1\n'.format(repo_name, repo_url)
+        )
+        with cd('/etc/yum.repos.d/'):
+            run('echo "{0}" >> automation-tools.repo'.format(repo_file))


What about failing the task or maybe printing a warning if repo_url is None? I think that adding a repo is a required step and would be better to fail if no repo_url are not provided.

Since the task will already do nothing if it isn't passed, i will just add an else that prints out a notice.

@elyezer how about..
"add_repo requires a repo_url to make any changes."

@JacobCallahan these tasks are intended to be used by an CI server. With that said, returning a non-zero return code as done by sys.exit(1) in other tasks ensure that the job run will fail if something is not right and will let us fix. Also will not proceed and give other strange errors.

Even though the docs will alert, the common practice over automation-tools is to fail earlier than later to avoid compromising the entire server. Will be easier to fix a unique failure and continue where it stepped manually.

@elyezer easy enough!

elyezer · 2014-12-22T19:29:34Z

ACK, pending comment.

Requires the repo_url be passed in the command. Example ------- ``` fab -H ibm-x3550m3-12.lab.eng.brq.redhat.com -u root -p '******' add_repo:'test','http://porkchop.devel.redhat.com/released/RHEL-7/7.0/Server/x86_64/os/' [ibm-x3550m3-12.lab.eng.brq.redhat.com] Executing task 'add_repo' [ibm-x3550m3-12.lab.eng.brq.redhat.com] run: echo "[test] name=test baseurl=http://porkchop.devel.redhat.com/released/RHEL-7/7.0/Server/x86_64/os/ enabled=1 " >> automation-tools.repo ```

JacobCallahan · 2014-12-23T14:16:11Z

All comments addressed

elyezer · 2014-12-29T03:39:31Z

Missed the update, merging now.

Added new function to create a compose repo file

elyezer · 2014-12-29T03:40:04Z

Karma given

JacobCallahan · 2014-12-29T17:23:46Z

Thanks, @elyezer

elyezer reviewed Dec 16, 2014
View reviewed changes

JacobCallahan force-pushed the master branch 2 times, most recently from c2551d1 to 507617e Compare December 17, 2014 15:32

elyezer reviewed Dec 17, 2014
View reviewed changes

JacobCallahan force-pushed the master branch from 507617e to 354d4c6 Compare December 22, 2014 18:41

elyezer reviewed Dec 22, 2014
View reviewed changes

JacobCallahan force-pushed the master branch from 354d4c6 to 9d0e1c0 Compare December 22, 2014 21:16

JacobCallahan force-pushed the master branch from 9d0e1c0 to 7fd54c6 Compare December 23, 2014 14:12

elyezer added a commit that referenced this pull request Dec 29, 2014

Merge pull request #101 from JacobCallahan/master

da04f9b

Added new function to create a compose repo file

elyezer merged commit da04f9b into SatelliteQE:master Dec 29, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new function to create a compose repo file #101

Added new function to create a compose repo file #101

JacobCallahan commented Dec 16, 2014

elyezer Dec 16, 2014

elyezer Dec 16, 2014

JacobCallahan Dec 16, 2014

elyezer commented Dec 16, 2014

cswiii commented Dec 16, 2014

cswiii commented Dec 16, 2014

JacobCallahan commented Dec 16, 2014

JacobCallahan commented Dec 17, 2014

elyezer Dec 17, 2014

JacobCallahan Dec 17, 2014

elyezer Dec 22, 2014

JacobCallahan Dec 22, 2014

elyezer Dec 22, 2014

JacobCallahan Dec 22, 2014

elyezer Dec 22, 2014

JacobCallahan Dec 22, 2014

JacobCallahan Dec 22, 2014

elyezer Dec 23, 2014

JacobCallahan Dec 23, 2014

elyezer commented Dec 22, 2014

JacobCallahan commented Dec 23, 2014

elyezer commented Dec 29, 2014

elyezer commented Dec 29, 2014

JacobCallahan commented Dec 29, 2014

		@@ -1157,6 +1157,18 @@ def performance_tuning(running_on_vm=True):
		run('tuned-adm profile throughput-performance')


		def generate_compose_repofile():

Added new function to create a compose repo file #101

Added new function to create a compose repo file #101

Conversation

JacobCallahan commented Dec 16, 2014

Example

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elyezer commented Dec 16, 2014

cswiii commented Dec 16, 2014

cswiii commented Dec 16, 2014

JacobCallahan commented Dec 16, 2014

JacobCallahan commented Dec 17, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elyezer commented Dec 22, 2014

JacobCallahan commented Dec 23, 2014

elyezer commented Dec 29, 2014

elyezer commented Dec 29, 2014

JacobCallahan commented Dec 29, 2014