Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a connection timeout option #145

Merged
merged 1 commit into from Dec 7, 2021

Conversation

JacobCallahan
Copy link
Member

This timeout is both available as a setting as well as when creating a Session instance.

@JacobCallahan JacobCallahan marked this pull request as draft November 30, 2021 19:43
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with some pending comments / questions.

Reviewed Draft MR, I can revisit though is anything changes!

broker/session.py Outdated Show resolved Hide resolved
broker/settings.py Outdated Show resolved Hide resolved
Also resolved a potential key error for AnsibleTower provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants