Introducing the Container provider #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-73
to
+80
| class VMBroker: | ||
| class Broker: |
|
Looks like I need to account for differences in unconfigured configs for containers to get the checks to pass on GH |
sambible
reviewed
Mar 31, 2022
|
One test failing because AT provider is actually trying to connect, so I need to look into that |
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
reviewed
Apr 5, 2022
swadeley
approved these changes
Apr 5, 2022
|
@swadeley @Griffin-Sullivan thanks for the reviews! The latest update should include and/or address everything so far |
JacobCallahan
force-pushed
the
brian
branch
2 times, most recently
from
2a46d69
to
f0aa330
Compare
spusateri
reviewed
Apr 28, 2022
| ``` | ||
| pip install broker[podman] | ||
| or | ||
| pip install broker[docker] |
There was a problem hiding this comment.
For some reason these commands fail when using zsh , I think its worth mentioning you may need to switch to bash for them to install correctly
This pr introduces the container provider. The first supported bind is Docker, though a Podman bind is in progress. A number of other supporting concepts have also been introduced, most notably are "binds". These are small abstraction layers around an external API that ease the integration into Broker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces the container provider.
The first supported bind is Docker, though a Podman bind is in progress.
A number of other supporting concepts have also been introduced, most
notably are "binds". These are small abstraction layers around an
external API that ease the integration into Broker.