Refactor logging #11332
Closed
Refactor logging #11332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JacobCallahan
requested changes
Apr 25, 2023
| @@ -2,7 +2,7 @@ | |||
| from pathlib import Path | |||
|
|
|||
| import pytest | |||
| from broker import Broker | |||
| from broker.broker import Broker | |||
There was a problem hiding this comment.
Raised a question about this in the Broker PR, so I won't repeat it further in this PR, but this is likely a blocker for me.
| @@ -24,6 +25,7 @@ def allow_repo_discovery(target_sat): | |||
| @pytest.fixture(autouse=True, scope="session") | |||
| def relax_bfa(session_target_sat): | |||
| """Relax BFA protection against failed login attempts""" | |||
| logger.info('xxx inside relax_bfa fixture body') | |||
There was a problem hiding this comment.
natural language is typically easy enough to differentiate in logs without trigger characters
Suggested change
| logger.info('xxx inside relax_bfa fixture body') | |
| logger.info('inside relax_bfa fixture body') |
There was a problem hiding this comment.
sorry, those are my working and debugging logs, so i can easily find and remove them when i'm finished :D
| @@ -29,6 +29,7 @@ def test_positive_ping(target_sat): | |||
|
|
|||
| :expectedresults: Overall and individual services status should be 'ok'. | |||
| """ | |||
| logger.info("xxx inside test body") | |||
There was a problem hiding this comment.
same comment as before
Suggested change
| logger.info("xxx inside test body") | |
| logger.info("inside test body") |
|
This pull request has not been updated in the past 45 days. |
|
This pull request is now being closed after stale warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to unify and add a proper structure to the logs.
logzeroand relying purely on nativelogginglibrary