Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Add coverage for BZ#2092039 and update few docstrings #13242

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[6.15.z] Add coverage for BZ#2092039 and update few docstrings #13242

merged 2 commits into from
Dec 5, 2023

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Dec 1, 2023

Manual CP of #13187

Fixes #13234

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 1, 2023
@vsedmik vsedmik self-assigned this Dec 1, 2023
@vsedmik vsedmik requested a review from a team as a code owner December 1, 2023 20:06
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 4, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k 'mismatch or import_incremental_yum_repo'

@vsedmik vsedmik added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Dec 4, 2023
@JacobCallahan
Copy link
Member

@vsedmik can you check into the PRT run? It looks like both tests failed.

@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 4, 2023

@JacobCallahan PRT is hitting this issue: pulp/pulpcore#4777 (also seen in 6.15.0 snap 1 results)
So the failure is expected. Should be fixed in next snap.

JacobCallahan
JacobCallahan approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on changes, pick looks sane.

@vsedmik vsedmik linked an issue Dec 5, 2023 that may be closed by this pull request
[Failed-AutoCherryPick] - Add coverage for BZ#2092039 and update few docstrings #13234
Closed
@vsedmik vsedmik merged commit 5643a65 into SatelliteQE:6.15.z Dec 5, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed-AutoCherryPick] - Add coverage for BZ#2092039 and update few docstrings
2 participants
@vsedmik @JacobCallahan