codecoverage bug2173870 #14273
Merged
codecoverage bug2173870 #14273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanpliu
added
CherryPick
lhellebr
requested changes
Mar 7, 2024
yanpliu
force-pushed
the
codecoverage_2173870
branch
from
7cb9861
to
a749141
Compare
yanpliu
force-pushed
the
codecoverage_2173870
branch
from
8d035be
to
28a6326
Compare
lhellebr
reviewed
Mar 13, 2024
lhellebr
approved these changes
Mar 13, 2024
yanpliu
force-pushed
the
codecoverage_2173870
branch
from
92b3a20
to
d4173cd
Compare
robottelo/utils/virtwho.py
Outdated
Comment on lines
594
to
596
| runcmd("systemctl stop virt-who") | ||
| runcmd("pkill -9 virt-who") | ||
| runcmd(f"virt-who -{option}") |
There was a problem hiding this comment.
Please use single quotes wherever possible, to ensure consistency :)
There was a problem hiding this comment.
@Gauravtalreja1 Thank you very much for your suggestion, have already updated
Co-authored-by: Gaurav Talreja <gauravtalreja1@gmail.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Gauravtalreja1
approved these changes
May 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
* codecoverage bug2173870 * update the code for f-format and comments * fix conflict and format issue * update to fix conflict * update to fix conflict * use nested list comprehensions to replace loop * replace double quotes with single quotes * remove the duplicated \n * Add the description of the methods * Update the pre-commit for description * Update robottelo/utils/virtwho.py Co-authored-by: Gaurav Talreja <gauravtalreja1@gmail.com> * resolve conflict * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Gaurav Talreja <gauravtalreja1@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit c58fe8e)
Gauravtalreja1
pushed a commit
that referenced
this pull request
May 16, 2024
codecoverage bug2173870 (#14273) * codecoverage bug2173870 * update the code for f-format and comments * fix conflict and format issue * update to fix conflict * update to fix conflict * use nested list comprehensions to replace loop * replace double quotes with single quotes * remove the duplicated \n * Add the description of the methods * Update the pre-commit for description * Update robottelo/utils/virtwho.py Co-authored-by: Gaurav Talreja <gauravtalreja1@gmail.com> * resolve conflict * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Gaurav Talreja <gauravtalreja1@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit c58fe8e) Co-authored-by: yanpliu <yanpliu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code coverage Bug2173870
Test Case : PASS